Failure to upgrade database with 10k external members

[alin-rautoiu]

Which Umbraco version are you using?

16.0.0

Bug summary

When upgrading Umbraco from Version 15.4.1 to 16.0.0 I receive the following error message:

The server supports a maximum of 2100 parameters. Reduce the number of parameters and resend the request.
While debugging I came to the conclusion that the large number of registered members is at fault.

Specifics

I think this is related to the changes introduced in #19273. Inside BackOfficeExternalLoginProviders.cs, when calling InvalidateSessionsIfExternalLoginProvidersChanged it sees as a registered external login provider only the schema for backoffice users, Umbraco.*. Which wouldn't be a problem if the table umbracoExternalLogin wouldn't also hold the logins for the external users. As such, it tries to invalidate all logins with the login provider UmbracoMembers.*.

Steps to reproduce

1. Have an Umbraco 15.4.* instance.
2. Implement and external login provider for members. I have followed the instructions from here.
3. Have more than 2100 members registered to an external login provider.
4. Make sure that the members have logged on so that the umbracoExternalLogin is populated. Alternativly just manually populate the table with dummy data.
5. Try to upgrade the project to Umbraco 16.0.0. The problem might arise simply while rebooting the application if the members count increased sufficiently during its runtime.

Expected result / actual result

1. I expect to be able to upgrade the project to version 16.0.0. regardless of the number of external registered members.
2. I expect that since I haven't removed the external login provider used by my external members, their logins should not be invalidated.

[github-actions]

Hi there @alin-rautoiu!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[kjac]

Thanks for the detailed issue report @alin-rautoiu ❤️

This has been fixed in #19766 for v13.10 and v16.2