15.2 Rollback - Hangs / Crashes browser when highlighting large JSON structure

[InfiniteSpirals]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.2.1

Bug summary

When attempting to rollback on documents which make extensive use of block list editors, often the browser becomes unresponsive, which I believe is due to the change highlighting running in browser with vast amounts of JSON to compare.

Specifics

We notice that it's very easy to end up with a significant amount of JSON when using an invariant block list editor on a vary by culture doctype, due to the fact all variants are stored in a single property across all cultures.

Steps to reproduce

Create a document with a block list editor and create a vast amount of content within that block list editor, then attempt to rollback.

Expected result / actual result

Ideally, it would function in a timely manner. However, given the size of text, not sure if this is possible. Possibly the highlighting could be disabled as an option, or the comparisons could be rendered async on the server, scoping language variants to only the selected language for rollback.

[github-actions]

Hi there @InfiniteSpirals!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[InfiniteSpirals]

Commenting here as the site this affects for us is near to launch and this has become a major roadblock.

[leekelleher]

Fixed in #21426, for v17.2.0.

[InfiniteSpirals]

Fantastic news, thanks all!