fix: fix SQL syntax error in getPageviewExpandedMetrics query

[travzhang]

reproduce the route: /websites/3638e7d2-7433-41b8-a2b6-2ec937faaecf?view=path
database version: PostgreSQL 13.22 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5), 64-bit

[vercel]

@travzhang is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes critical PostgreSQL syntax errors in the getPageviewExpandedMetrics function. The changes address two specific SQL syntax issues: first, adding the required AS keyword for column aliases in the SELECT clause (line 89), and second, fixing the GROUP BY clause to reference the actual column expression instead of the alias 'name' (line104). These modifications ensure the query executes properly in PostgreSQL environments, resolving database compatibility issues that would cause the expanded pageview metrics functionality to fail entirely. The fix targets the relational query implementation within the pageviews query module, which handles detailed analytics breakdowns including per-page and per-referrer data aggregations.

Important Files Changed

Filename	Score	Overview
src/queries/sql/pageviews/getPageviewExpandedMetrics.ts	5/5	Fixed PostgreSQL syntax errors by adding AS keyword for column alias and correcting GROUP BY clause

Confidence score: 5/5

• This PR is safe to merge with minimal risk as it only fixes SQL syntax errors
• Score reflects straightforward syntax corrections that resolve database compatibility issues without changing business logic
• No files require special attention as the changes are simple and targeted syntax fixes

Sequence Diagram

sequenceDiagram
    participant User
    participant "API Layer" as API
    participant "getPageviewExpandedMetrics" as Main
    participant "runQuery" as RunQuery
    participant "relationalQuery" as Postgres
    participant "clickhouseQuery" as ClickHouse
    participant "Database" as DB

    User->>API: "Request expanded pageview metrics"
    API->>Main: "getPageviewExpandedMetrics(websiteId, parameters, filters)"
    Main->>RunQuery: "runQuery({PRISMA: relationalQuery, CLICKHOUSE: clickhouseQuery})"
    
    alt PostgreSQL Database
        RunQuery->>Postgres: "relationalQuery(websiteId, parameters, filters)"
        Postgres->>Postgres: "parseFilters(filters, {joinSession})"
        Postgres->>Postgres: "Build SQL query with AS aliases"
        Postgres->>DB: "rawQuery(SQL with column AS name)"
        DB-->>Postgres: "Return metrics data"
        Postgres-->>RunQuery: "PageviewExpandedMetricsData[]"
    else ClickHouse Database
        RunQuery->>ClickHouse: "clickhouseQuery(websiteId, parameters, filters)"
        ClickHouse->>ClickHouse: "parseFilters(filters)"
        ClickHouse->>ClickHouse: "Build ClickHouse SQL query"
        ClickHouse->>DB: "rawQuery(ClickHouse SQL)"
        DB-->>ClickHouse: "Return metrics data"
        ClickHouse-->>RunQuery: "{x: string, y: number}[]"
    end
    
    RunQuery-->>Main: "Query results"
    Main-->>API: "Formatted metrics data"
    API-->>User: "Expanded pageview metrics response"

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}