-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix/direct url prisma #3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix/direct url prisma #3780
Conversation
|
@raunakgurud09 is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
Greptile OverviewGreptile SummaryAdded
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant App as Umami Application
participant Prisma as Prisma Client
participant Pool as Connection Pooler<br/>(PgBouncer)
participant DB as PostgreSQL Database
Note over App,DB: Before this PR (using only DATABASE_URL)
App->>Prisma: Initialize client with DATABASE_URL
Prisma->>Pool: Connect via pooler for queries
Pool->>DB: Execute queries
Prisma->>Pool: Try migrations via pooler
Pool-->>Prisma: ❌ May fail (pooler limitations)
Note over App,DB: After this PR (with directUrl support)
App->>Prisma: Initialize with DATABASE_URL + DIRECT_DATABASE_URL
Prisma->>Pool: Regular queries via DATABASE_URL
Pool->>DB: Execute queries
Prisma->>DB: Migrations via DIRECT_DATABASE_URL (bypass pooler)
DB-->>Prisma: ✅ Migrations succeed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| datasource db { | ||
| provider = "postgresql" | ||
| url = env("DATABASE_URL") | ||
| directUrl = env("DIRECT_DATABASE_URL") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: trailing whitespace at end of line
| directUrl = env("DIRECT_DATABASE_URL") | |
| directUrl = env("DIRECT_DATABASE_URL") |
Prompt To Fix With AI
This is a comment left during a code review.
Path: prisma/schema.prisma
Line: 10:10
Comment:
**style:** trailing whitespace at end of line
```suggestion
directUrl = env("DIRECT_DATABASE_URL")
```
How can I resolve this? If you propose a fix, please make it concise.
No description provided.