Fix image preview offset #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a hardcoded offset of `1` for the borders. With @ulyssa's fix for vertical splits, that can be removed now, as it diplaces all previews one character too much to the right. There some other offset bugs related to the layout-by-width in `get_render_format` not being replicated by `line_preview`, which should probably by unified some way.
ulyssa
approved these changes
Nov 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a hardcoded offset of
1for the borders. With @ulyssa's fix for vertical splits, that can be removed now, as it displaces all previews one character too much to the right.There some other offset bugs related to the layout-by-width in
get_render_formatnot being replicated byline_preview, which should probably by unified some way.