Skip to content

global bypass toggle #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulville merged 5 commits into from
Jul 15, 2024
Merged

global bypass toggle #21

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a20a435
feat: toggle bypass
akiyiwen Jul 11, 2024
4d5d5ee
improve: get bypass state before build menu
akiyiwen Jul 13, 2024
70ec50d
improve: bypass item style
akiyiwen Jul 13, 2024
c926f39
fix: add bypass item height to scrollbar policy
akiyiwen Jul 13, 2024
8c3a698
eslint
akiyiwen Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions [email protected]/extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const EEPSIndicator = GObject.registerClass(
this.lastUsedInputPreset = ' ';
this.lastUsedOutputPreset = ' ';
this.lastPresetLoadTime = 0;
this.enableBypass = false;
this.command = [];
this.settings = settings;
this.appDesktopFile = 'com.github.wwmm.easyeffects.desktop';
Expand Down Expand Up @@ -117,6 +118,21 @@ const EEPSIndicator = GObject.registerClass(
}
}

_enableGlobalBypass(state) {
this.enableBypass = state;
const bypassOption = state ? "1": "2";
const command = this.command.concat(["-b", bypassOption]).join(" ");
try {
GLib.spawn_command_line_async(command);
} catch (error) {
Main.notify(
_('An error occurred while trying to toggle bypass'),
_(`Error:\n\n${error}`)
);
logError(error);
}
}

_addCategoryTitle(categoryName, categoryIconName) {
let _title = new PopupMenu.PopupSeparatorMenuItem(
`${_(categoryName)}:`
Expand Down Expand Up @@ -165,6 +181,12 @@ const EEPSIndicator = GObject.registerClass(
this.menu._getMenuItems().forEach(item => {
item.destroy();
});
// Add switch menu item to toggle global bypass
const toggleBypassItem = new PopupMenu.PopupSwitchMenuItem(_("Enable global bypass"), this.enableBypass, {});
toggleBypassItem.connect("toggled", (item, state) => {
this._enableGlobalBypass(state);
})
this.menu.addMenuItem(toggleBypassItem);
// Category Title: "Output Presets" (As how the command did output it)
if (outputCategoryName)
this._addCategoryTitle(outputCategoryName, 'audio-speakers-symbolic');
Expand Down Expand Up @@ -370,6 +392,11 @@ const EEPSIndicator = GObject.registerClass(
Main.notify(_(erMessage), _(`Error:\n\n${e}`));
logError(e);
}

// Get global bypass
const bypassResponse = await this.execCommunicate(this.command.concat(["-b", "3"]));
const bypassEnabled = (bypassResponse.trim() === "1")
this.enableBypass = bypassEnabled;
}
}

Expand Down