autosplit: take image files with uppercase extensions into account#5269
Merged
glenn-jocher merged 4 commits intoultralytics:masterfrom Oct 20, 2021
Merged
autosplit: take image files with uppercase extensions into account#5269glenn-jocher merged 4 commits intoultralytics:masterfrom
glenn-jocher merged 4 commits intoultralytics:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
👋 Hello @jdfr, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
Removes additional variable (capital variable names are also only for global variables), and uses the same methodology as implemented earlier in datasets.py L409.
Member
|
@jdfr PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
…ltralytics#5269) * take image files with uppercase extensions into account in autosplit * case fix * Refactor implementation Removes additional variable (capital variable names are also only for global variables), and uses the same methodology as implemented earlier in datasets.py L409. * Remove redundant rglob characters Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMG_FORMATS contains lowercase versions of image file extensions.
In all other uses of IMG_FORMATS, care is taken to take into account image files regardless of the extension's case. However, the autosplit() function doesn't: it silently fails to include files whose extensions have any uppercase letter. This is not a problem on Windows, but has bitten me on Linux. This commit fixes the problem.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Refined image file filtering mechanism in the dataset loading process.
📊 Key Changes
🎯 Purpose & Impact