Closed
Conversation
Fixes out of bounds labels that seem to affect ~10% of images in dataset.
…named it to evaluation
Contributor
There was a problem hiding this comment.
👋 Hello @NaelsonDouglas, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
Member
|
/rebase experiment after #5255 adding Organization secret ACTIONS_TOKEN |
eval fix
Member
|
@NaelsonDouglas I need you to merge master into your fork before I can merge this PR. Please run the following commands: git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git merge upstream/master
git push -u origin -f |
Author
There were some errors, looks like I didnt manage to make it. :( |
Member
|
@NaelsonDouglas I will close this PR, please submit a new one from the latest master then, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
There was a built-in name shadowing pitfall on eval.py where the name eval, which is a Python built-in method, was being used as a variable.;
If for any reason the method gets called within that context, it would cause a hard to detect bug because eval(arg) would not be a method being called, but a variable being called as a method.
Solution
Changed the variable name to evaluation
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhancements and bug fixes for YOLOv5 workflows.
📊 Key Changes
.pre-commit-config.yamlandsetup.cfgto aid in code quality.CONTRIBUTING.md.train.py.🎯 Purpose & Impact