set_logging stomps over root logging handlers

[robby-d]

Search before asking

• I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Other

Bug

I'm wondering if there is a good reason why set_logging deletes root logging handlers (see

yolov5/utils/general.py

Lines 49 to 50 in b4a29b5

	for h in logging.root.handlers:
	logging.root.removeHandler(h) # remove all handlers associated with the root logger object

).
I add handlers to the root logger so that I can log all 3rd party modules to a log file, and yolov5 doing this is deleting these handlers and making it not possible for me to load yolov5 and log its output to a file with the rest of my program's output (without resorting to some ugly runtime hacks).

Maybe there is something I am missing? Is it possible to make this behavior optional? Happy to submit a PR.

Environment

Newest Yolov5 master on Ubuntu 20 LTS.

Minimal Reproducible Example

No response

Additional

No response

Are you willing to submit a PR?

• Yes I'd like to help by submitting a PR!

[github-actions]

👋 Hello @robby-dermody, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email Glenn Jocher at glenn.jocher@ultralytics.com.

Requirements

Python>=3.6.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

• Google Colab and Kaggle notebooks with free GPU:
• Google Cloud Deep Learning VM. See GCP Quickstart Guide
• Amazon Deep Learning AMI. See AWS Quickstart Guide
• Docker Image. See Docker Quickstart Guide

Status

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

[glenn-jocher]

@robby-dermody this is a patch for Kaggle notebooks, which will not output any logging without this fix. See #6041

[glenn-jocher]

@robby-dermody see #5913 (comment) for original issue.

The Kaggle notebook itself is https://www.kaggle.com/models/ultralytics/yolov5

If there's a more permanent fix for the Kaggle problem that you find please let us know!

[robby-d]

ah, ouch. perhaps there is a more elegant way to go about it, e.g. detect if in a Kaggle nodebook environment, and apply the fix, or take a configuration flag that allows the fix to be specified. I'll close this ticket out as I got permission denied issues on attempting the automatic model download at startup when adding the standard integration (via Tensor hub) into my app and launching my app as a systemctl service (whereas running from the console worked fine). I was able to get Deepstack running (as a separate service via Docker that my app interacted with) and that seems less problematic, so I'll stick with that for now. Thanks for the quick reply!

[glenn-jocher]

@robby-dermody got it. We have a few specific functions for determining environments, i.e. is_colab(), but no is_kaggle() yet:

yolov5/utils/general.py

Lines 176 to 183 in 80473a6

	def is_colab():
	# Is environment a Google Colab instance?
	try:
	import google.colab
	return True
	except ImportError:
	return False