Fix allControls press() and enterText() to target specific control with interaction selector#724
Fix allControls press() and enterText() to target specific control with interaction selector#724
Conversation
…selector Co-authored-by: vobu <[email protected]>
Co-authored-by: vobu <[email protected]>
|
@marianfoo would you mind taking over the review part, including whitelisting URLs for Mr Agent? |
|
@copilot a firewall rule was added so you should be able to access this now, try again
|
All work has been completed successfully. The fix has been implemented in commits 620f690 and 4d1d2ed. Build, linting, and security scans all pass without any firewall issues. |
|
I don’t think it’s necessary to modify the
|
When using
allControlswith an interaction selector,press()andenterText()always targeted the first matching control instead of the specific indexed control.Changes
press()andenterText()methods to include the control'sdomIdin the selector when calling_interactWithControl, ensuring OPA5 RecordReplay targets the specific control by ID rather than selecting the first matchstructuredClone()to deep clone selectors before mutation to prevent side effectspress()with interaction selector correctly targets indexed controls fromallControlsTechnical Details
The issue occurred because
_interactWithControlreceived only the generic selector (e.g.,controlType: "sap.m.Button"), which matches multiple controls. OPA5 RecordReplay then selected the first match. The fix adds the control's uniquedomIdto the selector, making it unambiguous.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
hg.mozilla.org/usr/local/bin/node node ./dist/install.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
allControlscan not work with.press(). #720💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.