fix issue with code pasting from VS Code when at the last line of code#5106
Merged
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nperez0111
reviewed
Apr 30, 2024
| // if the cursor is at the absolute end of the document, insert the code block before the cursor instead | ||
| // of replacing the selection as the replaceSelectionWith function will cause the insertion to | ||
| // happen at the previous node | ||
| if (view.state.selection.from === view.state.doc.nodeSize - (1 + (view.state.selection.$to.depth * 2))) { |
Contributor
There was a problem hiding this comment.
I'm not going to pretend that I completely understand this. What is tripping me up is the * 2.
But otherwise this looks right
Member
Author
There was a problem hiding this comment.
The 2 is the offset of a prosemirror node to the next one. If you for example have a nested node - the wrapping node will always add an offset of 1 at the beginning and the end which you have to account for if you want to find the correct position after said node.
nperez0111
approved these changes
Apr 30, 2024
This was referenced Jun 19, 2024
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR fixes an minor issue where code copied from VSCode wouldn't be correctly pasted at the end of a document because
replaceSelectionWithwould cause a buggy insertion when the end position of the selection is in a node at the end of the document.How did you accomplish your changes
I'm checking if the cursor is at the end - if so I insert the code block before the current position - otherwise I use the replaceSelectionWith function
How have you tested your changes
Tested it locally in the default demo
How can we verify your changes
See above
Checklist