Export getTextSerializersFromSchema helper, and fix typo in its name#2750
Merged
bdbch merged 2 commits intoueberdosis:mainfrom May 17, 2022
Merged
Export getTextSerializersFromSchema helper, and fix typo in its name#2750bdbch merged 2 commits intoueberdosis:mainfrom
getTextSerializersFromSchema helper, and fix typo in its name#2750bdbch merged 2 commits intoueberdosis:mainfrom
Conversation
For plugins and other user-defined extensions, it's useful to be able to be able to use the text-serializers-from-schema helper, like is done in the built-in clipboardTextSerializer extension (https://github.com/ueberdosis/tiptap/blob/43611ea2e70d3dc66ff907ba7ca377bf74814543/packages/core/src/extensions/clipboardTextSerializer.ts#L21).
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For plugins and other user-defined extensions, it's useful to be able to be able to use the text-serializers-from-schema helper, like is done in the built-in
clipboardTextSerializerextension:tiptap/packages/core/src/extensions/clipboardTextSerializer.ts
Line 21 in 43611ea
This is necessary to be able to fully take advantage of the
getText/generateTextmethods introduced here #1875, if you want to be able to generate text for individual ranges/nodes in a document rather than the entire document.This PR exports that
getTextSerializersFromSchemafunction, and also corrects a typo in its name (file and function)—Seralizers-->Serializers. Related to #2740 but doesn't solve its particular ask.