Make storeDocumentHooks throw errors instead of silently ignoring them.#904
Closed
Make storeDocumentHooks throw errors instead of silently ignoring them.#904
Conversation
Make debounce function asynchronous and improve usage Refactor the debounce function to return a Promise, enabling better handling in async workflows. Adjust related code to properly await hooks execution and error catching. Simplify logic in storeDocumentHooks for improved readability and maintainability.
janthurau
force-pushed
the
feature/throwErrorInStoreDocumentHooks
branch
from
6ab3de9 to
1893b60
Compare
Contributor
Author
|
nevermind. this breaks the entire hook architecture (as you won't be able to stop the hook chain for a given hook name) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make debounce function asynchronous and improve usage
Refactor the debounce function to return a Promise, enabling better handling in async workflows. Adjust related code to properly await hooks execution and error catching.
Simplify logic in storeDocumentHooks for improved readability and maintainability.
related to #895