fix(server): Send permission denied event when token sync callback throws#1039
Closed
n-siddarth wants to merge 1 commit intoueberdosis:mainfrom
Closed
fix(server): Send permission denied event when token sync callback throws#1039n-siddarth wants to merge 1 commit intoueberdosis:mainfrom
n-siddarth wants to merge 1 commit intoueberdosis:mainfrom
Conversation
Author
|
@janthurau I was wondering, would it make more sense to implement this logic in the server or the provider? Ideally, the provider should respond to the Unauthorized CloseEvent, which does get emitted, but this doesn't seem to be the case as of now. |
Author
|
Had another thought, we could have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Token synchronization was introduced in #1001 . However, when the user-provided
tokenSyncCallbackthrows, indicating a failed token validation attempt, current behavior is to just close the websocket connection. This prevents onAuthenticationFailed hooks in the provider from being called. Instead,onAuthenticationFailedis only called after the client attempts to reconnect to the server after some duration.Solution
Before closing the websocket connection on a failed token validation attempt, we first send a permission denied message back to the client and then close the connection. This causes the provider to call onAuthenticationFailed hooks which is expected behavior.