HocuspocusProviderWebsocket always connects when we create an instance.

[Ayrat-Kh]

Description
There is no way preventing websocket provider from the initial connection.

Steps to reproduce the bug
Steps to reproduce the behavior:

1. Create an instance of HocuspocusProviderWebsocket.
2. Socket will start auto-conenction.

Expected behavior
There should an option to create in instance without auto connection. Otherwise the condition

if (!this.shouldConnect) {
    return;
}

doesn't make any sense.

Most likely we should be able to pass shouldConnect as a configuration.

Screenshot, video, or GIF

Environment?

• Hocuspocus version: 3.1.0

EDdt:
Additional:

I can create a PR soon, if I git confirmation that this is bug

[0xb4lamx]

any thoughts on this @janthurau 🙏

[janthurau]

is there a usecase where it makes sense to create the provider without it creating a connection? Happy to merge a PR that adds the option, just can't think of a use-case 🤔

[Ayrat-Kh]

I was thinking about a case where I want to create an instance: subscribe to the necessary events, and then at some point establish the connection(maybe I don't even establish the connection eventually).

That being said, I want to configure dependencies before I run the main app, and then later, when needed, establish a WebSocket connection.

Another question is that in the constructor, there is a check:

if (this.shouldConnect) {
   this.connect();
}

which is either misleading now, or the WebsocketProvider should support non-autoconnection.