Skip to content
This repository was archived by the owner on Apr 22, 2024. It is now read-only.

feat: add action outputs#47

Merged
p5 merged 2 commits into
mainfrom
add-action-outputs
Feb 29, 2024
Merged

feat: add action outputs#47
p5 merged 2 commits into
mainfrom
add-action-outputs

Conversation

@p5

@p5 p5 commented Feb 29, 2024

Copy link
Copy Markdown
Member

Closes #42

Creates action outputs pointing to the directory containing the built artifacts, the path to the ISO file and the path to the checksum file.
This has been documented in the README.md

I have also updated the CI job to use these outputs so we can validate it's all working as expected.

@p5 p5 marked this pull request as ready for review February 29, 2024 00:37
@p5 p5 requested a review from JasonN3 as a code owner February 29, 2024 00:37
@noelmiller

Copy link
Copy Markdown
Member

Awesome work on this! Once this is merged, could you refactor https://github.com/ublue-os/bazzite/blob/main/.github/workflows/build_iso.yml and https://github.com/ublue-os/bluefin/blob/main/.github/workflows/build_iso.yml to use the new outputs method and the updated version of the release?

@bsherman bsherman left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good improvement.

@p5 p5 added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit e2fbaa4 Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Output to action.yml and document it's usage

3 participants