Skip to content
This repository was archived by the owner on Apr 22, 2024. It is now read-only.

feat: add creation of sha256 checksum#30

Merged
noelmiller merged 2 commits into
mainfrom
add_sha256sum
Feb 24, 2024
Merged

feat: add creation of sha256 checksum#30
noelmiller merged 2 commits into
mainfrom
add_sha256sum

Conversation

@noelmiller

@noelmiller noelmiller commented Feb 23, 2024

Copy link
Copy Markdown
Member

Purpose

There is a desire by the team to include a sha256 checksum with every creation of an ISO.

Closes #29

What I did

Added bash command to create sha256 checksum after ISO creation is completed

Tests

Feel free to review build artifacts of recently completed Build ISO tests to validate function.

@noelmiller noelmiller requested a review from JasonN3 as a code owner February 23, 2024 23:12
@bsherman

Copy link
Copy Markdown

Am I missing something? I don't see the sha256 checksum files in artifacts on test ISO workflow.

@noelmiller

noelmiller commented Feb 24, 2024

Copy link
Copy Markdown
Member Author

Am I missing something? I don't see the sha256 checksum files in artifacts on test ISO workflow.

The artifact is downloaded as a zip file. I should probably rename that to .zip at this point.

@bsherman

Copy link
Copy Markdown

Am I missing something? I don't see the sha256 checksum files in artifacts on test ISO workflow.

The artifact is downloaded as a zip file. I should probably rename that to .zip at this point.

I don't see a zip file either. just ISO files

@noelmiller

noelmiller commented Feb 24, 2024

Copy link
Copy Markdown
Member Author

Am I missing something? I don't see the sha256 checksum files in artifacts on test ISO workflow.

The artifact is downloaded as a zip file. I should probably rename that to .zip at this point.

I don't see a zip file either. just ISO files

Click on one of the artifacts in this page and download it. it will download it as a .zip file: https://github.com/ublue-os/isogenerator/actions/runs/8026385034?pr=30

I'll fix the name of the file in a different PR to avoid confusion.

@bsherman

Copy link
Copy Markdown

Ok, downloaded the *.iso artifact which is actually a ZIP :-) and within i found both the iso and the checksum file.

and...

$ sha256sum -c base-main-38-CHECKSUM
base-main-38.iso: OK

@noelmiller noelmiller added this pull request to the merge queue Feb 24, 2024
Merged via the queue into main with commit 337e31c Feb 24, 2024
@noelmiller noelmiller deleted the add_sha256sum branch February 25, 2024 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate and publish signatures

3 participants