Skip to content

[WIP][ML-10118] Keep petastorm dataset/dataloader schema fields order the same with spark dataframe #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WeichenXu123 wants to merge 1 commit into from
Closed

[WIP][ML-10118] Keep petastorm dataset/dataloader schema fields order the same with spark dataframe #511

WeichenXu123 wants to merge 1 commit into from

Conversation

@WeichenXu123
Copy link
Collaborator

@WeichenXu123 WeichenXu123 commented Mar 21, 2020

[WIP]Keep petastorm dataset/dataloader schema fields order the same with spark dataframe.

mengxr
mengxr reviewed Mar 21, 2020
View reviewed changes
Copy link
Collaborator

@mengxr mengxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a small test that can send data directly to keras model.fit?

@WeichenXu123
Copy link
Collaborator Author

WeichenXu123 commented Mar 23, 2020

@mengxr
Because there's this PR #512
we don't need add a selected_field into TransformSpec. We can directly infer schema from transformed result(and schema field order will be the field order of the transformed result pandas dataframe).
Create a new PR #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mengxr mengxr mengxr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WeichenXu123 @mengxr