Add zaptest logger option to wrap zap.Option's

[iaroslav-ciupin]

Synopsis

This PR adds feature suggested in #609

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #610 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   97.23%   97.38%   +0.14%     
==========================================
  Files          40       40              
  Lines        2063     2102      +39     
==========================================
+ Hits         2006     2047      +41     
+ Misses         49       47       -2     
  Partials        8        8

Impacted Files	Coverage Δ
zaptest/logger.go	100% <100%> (ø)	⬆️
writer.go	100% <0%> (ø)	⬆️
sink.go	100% <0%> (+7.4%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7e266...3e7caed. Read the comment docs.

[akshayjshah]

Thanks for the PR, @iaroslav-ciupin! This feature would be great. However, I'd rather not replicate each of the core zap package's options. Instead, I'd rather have the zaptest package provide a generic adapter for the base options:

• The loggerOptions struct should have a field of zap.Options.
• Add a function that converts any number of zap.Options to a single zaptest.Option:

func WrapOptions(opts ...zap.Option) LoggerOption { ...implementation...}

• In NewLogger, we'd pass all the options on the loggerOptions struct to zap.New.

[iaroslav-ciupin]

@akshayjshah Thank you for your reply! I've adjusted PR and proposal accordingly. Please have a look ;)

[akshayjshah]

Looks great!