Use fixed-width ISO8601 formatting#362
Merged
Merged
Conversation
|
@htrendev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah, @peter-edge and @jcorbin to be potential reviewers. |
akshayjshah
approved these changes
Mar 9, 2017
Contributor
akshayjshah
left a comment
There was a problem hiding this comment.
Looks good - thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal change of how the milliseconds part in iso8601 strings is formatted. Currently any trailing zeroes are removed, which produces different length time strings. Depending on tab size settings in terminal, this may results in level and message columns getting out of alignment (not observed in the example below, but happens in terminal if tab size is set to 4).
Keeping the trailing zeroes, preserves the alignment of log messages and makes it a bit easier on the eyes.
I'm not sure if such a change needs a test, but I'll write one if indeed required.Updated existing test to check for trailing zeroes.Before opening your pull request, please make sure that you've:
make test); and finally,make lint).Thanks for your contribution!