zap: Add ParseAtomicLevel func#1048
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
=======================================
Coverage 98.11% 98.12%
=======================================
Files 48 48
Lines 2074 2080 +6
=======================================
+ Hits 2035 2041 +6
Misses 30 30
Partials 9 9
Continue to review full report at Codecov.
|
sywhang
reviewed
Jan 14, 2022
Co-authored-by: Sung Yoon Whang <sungyoonwhang@gmail.com>
sywhang
approved these changes
Jan 14, 2022
Contributor
sywhang
left a comment
There was a problem hiding this comment.
Thank you for the contributions! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1047 this PR adds a
zap.ParseAtomicLevel()func which enables the user to construct a log level based on ASCII text input.Usage