Fix bug for Issue: #554 MapObjectEncoder does not match jsonEncoder#1017
Conversation
MapObjectEncoder does not match jsonEncoder (uber-go#554) Problem was that new openNamespaces that are created during AppendObject() call were not closed. Note, ONLY new openNamespaces that are created during AppendObject() are closed. If they were created at prior to AppendObject() call, it will remain open till EncodeEntry() call completes.
|
|
sammyrnycreal
changed the title
|
Hi @moisesvega @manjari25, Can I get some 👀 on this PR and have it merged in, if possible? |
|
Hi @abhinav Do you know whom I can ping to get this PR reviewed and merged in? |
|
@sammyrnycreal Thanks for the fix and apologies for the delay! Internal issue ref: GO-987 |
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
=======================================
Coverage 98.20% 98.21%
=======================================
Files 47 47
Lines 2064 2069 +5
=======================================
+ Hits 2027 2032 +5
Misses 29 29
Partials 8 8
Continue to review full report at Codecov.
|
abhinav
left a comment
abhinav
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix @sammyrnycreal!
|
Thanks again, @sammyrnycreal! |
|
@abhinav Anytime. |
4 participants
Fix bug
MapObjectEncoder does not match jsonEncoder #554
Problem was that new openNamespaces that are created during AppendObject() call were not closed.
Note, ONLY new openNamespaces that are created during AppendObject() are closed. If they were created at prior to AppendObject() call, it will remain open till EncodeEntry() call completes.
make allpasses all test.@jkanywhere This will resolve the issue you raised. I included the test you wrote up here Thank you, that helped me find the bug.