feat(bazel): support archive mode #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywhang
reviewed
Jun 12, 2025
Contributor
Author
|
I can look |
sywhang
reviewed
Jun 12, 2025
| go 1.23.0 | ||
|
|
||
| require go.uber.org/mock v0.4.0 | ||
| require go.uber.org/mock v0.5.3-0.20250612195617-359202c7b2fe |
sywhang
approved these changes
Jun 12, 2025
linzhp
pushed a commit
that referenced
this pull request
Jul 1, 2025
Hi! In #259 was introduced archive mode for bazel rule, but no support for mock_names. This PR added `mock_names` attr to `_gomock_archive` rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the broken reflect mode in the bazel aspect, in favor of archive mode which was landed in #258