Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflow configuration to support testing on Java 21 by updating the Java version matrix and adding a manual workflow trigger.
- Added the workflow_dispatch trigger to allow manual CI runs.
- Updated the Java version matrix to include Java 17 and 21.
- Changed the checkout action version from v4 to v3.
Comments suppressed due to low confidence (1)
.github/workflows/CI.yml:55
- Reverting the checkout action from v4 to v3 might introduce unintended issues; please confirm that this downgrade is intentional and does not impact the CI reliability.
uses: actions/checkout@v3
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CI workflow configuration to support Java 21 and streamline the JDK setup.
- Added a manual trigger via workflow_dispatch
- Updated the matrix configuration to include Java versions 17 and 21, replacing previous Java 8/11 versions
- Adjusted job steps to reflect the new JDK version configuration
bjagg
approved these changes
Jun 6, 2025
Member
bjagg
left a comment
bjagg
left a comment
There was a problem hiding this comment.
Hold off on merging until we release v5.10.1 for uPortal 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.