fix invalid args type on node v14 #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahallicks
approved these changes
Jun 30, 2020
|
Any chance of getting this merged? |
Contributor
|
cc @typicode can you merge and release this quick change so Hotel works on the latest Node? |
Contributor
|
@typicode please, release new version :) |
exah
approved these changes
Feb 22, 2021
|
this appears to still be an issue in node16 and this fix is still good. Please merge |
|
merged this fix and published to https://www.npmjs.com/package/@qshan/hotel if you want merge/publish access lmk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR fixes a breaking change with node v14 where number is no longer a valid entry for
fs.writeFileSync.In reason of that, on node v14, we will receive the error below when the daemon attempts to register the process.pid.
The quick fix is to change the file
hotel/lib/pid-file.jsto parse the process.pid to string.I am happy to receive any feedback on this PR.
I tested the changes on node v13, and it works just fine, so I am not expecting that machine running old versions of node will be impacted.
😁