Use checker-qual 4.1.0#198
Conversation
📝 WalkthroughWalkthroughThis PR updates CI infrastructure and dependency management: the Maven test workflow now runs exclusively on JDK 17 and 18, and the Checker Framework ChangesInfrastructure Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/maven_tests.yml (1)
42-50: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winRemove obsolete exclusion rules.
The exclusion rules for JDK 9, 10, 12, and 14 on macOS are now obsolete since these versions are no longer in the test matrix (line 38 specifies only JDK 17 and 18). These exclusions serve no purpose and should be removed to avoid confusion.
♻️ Remove the obsolete exclude block
jdk: [ 17,18 ] # The below configurations are no longer available on github runners and is not supported by the # setup-java action, nor are they available from the supported distributions. # See https://github.com/actions/setup-java for details - exclude: - - os: macos-latest - jdk: 9 - - os: macos-latest - jdk: 10 - - os: macos-latest - jdk: 12 - - os: macos-latest - jdk: 14 env:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/maven_tests.yml around lines 42 - 50, Remove the obsolete entries from the GitHub Actions YAML exclude block: delete the four macOS exclusions that target jdk: 9, 10, 12, and 14 under the exclude: list (the entries shown in the diff), leaving the exclude block empty or removing it entirely if no other exclusions remain; this ensures the matrix (currently using JDK 17 and 18) has no meaningless exclusions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pom.xml`:
- Line 443: Upgrade to Checker Framework 4.1.0 may remove deprecated build
script and deprecated Called Methods Checker names and modify
AnnotatedTypeFactory visibility; search the repo for usages of the removed build
script path (checker/bin-devel/build.sh), any occurrences of the deprecated
Called Methods Checker names "builder", "object.construction", or
"objectconstruction" (e.g., in annotations, config files, or tests) and any
classes that extend AnnotatedTypeFactory, then update or remove usages: replace
deprecated names with the current checker annotations/config keys, adjust
subclass code to use the new AnnotatedTypeFactory API (refactor accesses to
now-nonpublic members to supported APIs), and remove any CI/build references to
the deleted build script so the project compiles against 4.1.0.
---
Outside diff comments:
In @.github/workflows/maven_tests.yml:
- Around line 42-50: Remove the obsolete entries from the GitHub Actions YAML
exclude block: delete the four macOS exclusions that target jdk: 9, 10, 12, and
14 under the exclude: list (the entries shown in the diff), leaving the exclude
block empty or removing it entirely if no other exclusions remain; this ensures
the matrix (currently using JDK 17 and 18) has no meaningless exclusions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8059e4c3-4ccf-4f4f-8fa8-c38764e9ebec
📒 Files selected for processing (2)
.github/workflows/maven_tests.ymlpom.xml
No description provided.