feat(documents): add throwOnFail option to import methods#307
Merged
jasonbosco merged 1 commit intotypesense:masterfrom Jul 23, 2025
Merged
feat(documents): add throwOnFail option to import methods#307jasonbosco merged 1 commit intotypesense:masterfrom
throwOnFail option to import methods#307jasonbosco merged 1 commit intotypesense:masterfrom
Conversation
- adds `throwOnFail` to `import` and `importStream` for better error control - defaults `throwOnFail` to `true` to preserve existing failure behavior - allows bypassing import errors by setting `throwOnFail: false` - updates typings to propagate document schema type in import responses - enhances test coverage for both `throwOnFail` enabled and disabled modes
jasonbosco
approved these changes
Jul 23, 2025
Member
|
Published in v2.1.0-13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
throwOnFailtoimportandimportStreamfor better error controlthrowOnFailtotrueto preserve existing failure behaviorthrowOnFail: falsethrowOnFailenabled and disabled modesPR Checklist