-
Notifications
You must be signed in to change notification settings - Fork 58
Auto Imports, remove JS/TS config #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - Read the project’s [ARCHITECTURE.md](./ARCHITECTURE.md) to understand the basics of how the code base works. | ||
|
|
||
| Once you have made changes and added tests to confirm they work correctly, you can then open a PR and we'll work with you to polish it up and get it landed! | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for adding this! This is all the information i got super stuck on not having when i was first getting in to glint!
Very needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for adding tests!!
1e8bbc3 to
918cb33
Compare
|
This is great! Thanks for adding this <3 |
| const [] = 𝛄.blockParams["default"]; | ||
| { | ||
| // ... | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using these Greek letters makes the code/documentation less readable.
Why deviate from what is normally used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time of writing, these greek letters were already being used by Glint's "compiler" for transforming templates into type-checkable TS. Note that in the last year I changed these symbols to keywords like __glintDSL because I ran into upstream issues during the sourcemapping process due to the multi-byte unicode encoding for these characters.






See #130
Basic Support for Auto-Import (for all supported filetypes, including .gts)
You are now offered code completions for auto-imports, and selecting them will add the import at the top of the file.
Remove JS/TS configuration options
Previously we were attempting to read the JS/TS VScode configuration preferences in order to pass them through to the VS LSP within Glint, but since the goal is feature parity with the TS LSP such that you can (and should) disable the default TS LSP, we can't continue to use the default JS/TS config options because they get disabled then you disable the TS built-in extension. This PR replaces them with sensible hard-wired defaults, and we can consider adding configurable VS code preferences specific to Glint in a future PR.
Add localhost dev/debug instructions to CONTRIBUTING.md
This would have been very helpful for me getting up and running.
(Won't fix) Completions don't work on unclosed tags within
<template>Likely not fixable until we have some syntax-forgiving Glimmer parser.