Merged
Conversation
And make old task converters obsolete
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation and API for version 5 of the Activout.RestClient library, focusing on making JSON serialization pluggable and deprecating old task converter implementations.
- Updates README to document version 5 breaking changes and new JSON serialization approach
- Marks old task converter classes as obsolete in favor of TaskConverter3Factory
- Updates service registration to use the new TaskConverter3Factory
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates documentation with version 5 breaking changes, JSON serialization options, and removes completed TODO item |
| TaskConverterFactory.cs | Adds obsolete attribute to legacy task converter factory |
| TaskConverter2Factory.cs | Adds obsolete attribute to legacy task converter factory |
| TaskConverter2.cs | Adds obsolete attribute to legacy task converter implementation |
| TaskConverter.cs | Adds obsolete attribute to legacy task converter implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make old task converters obsolete