Create Activout.RestClient.Test.Json project to test both JSON implementations#82
Merged
Create Activout.RestClient.Test.Json project to test both JSON implementations#82
Conversation
… for both JSON implementations Co-authored-by: twogood <[email protected]>
Copilot
AI
changed the title
[WIP] Create a new Activout.RestClient.Test.Json project to run the same tests against both JSON implementations
Create Activout.RestClient.Test.Json project to test both JSON implementations
Jul 28, 2025
twogood
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new
Activout.RestClient.Test.Jsonproject that runs the same JSON-dependent test cases against bothActivout.RestClient.Json(System.Text.Json) andActivout.RestClient.Newtonsoft.Jsonimplementations.Changes Made
Activout.RestClient.Test.Jsonwith xUnit framework[Theory]and[InlineData]attributes to run tests with both implementationsMovieReviewsnamespaceRestClientTests- Core REST client functionality with JSON serialization/deserializationSerializationOrderTest- Tests serialization ordering behaviorSimpleValueObjectTest- Tests simple value object handlingImplementation Details
The solution uses a
JsonImplementationenum to parameterize tests across both implementations:Each test creates the appropriate REST client builder based on the implementation:
Test Results
All 25 tests pass successfully with both JSON implementations, ensuring compatibility and consistent behavior across both libraries.
Fixes #81.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.