Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR initiates a clean-up effort for the Newtonsoft.Json integration by centralizing default settings and supported media types. The changes include replacing references to JsonHelper with a new NewtonsoftJsonDefaults class, updating serializer and deserializer implementations, and removing the obsolete JsonHelper file.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Activout.RestClient.Newtonsoft.Json/RestClientBuilderNewtonsoftJsonExtensions.cs | Updated to use NewtonsoftJsonDefaults for default serializer settings |
| Activout.RestClient.Newtonsoft.Json/NewtonsoftJsonSerializer.cs | Replaced JsonHelper reference with NewtonsoftJsonDefaults for media types |
| Activout.RestClient.Newtonsoft.Json/NewtonsoftJsonDeserializer.cs | Similar media types update using NewtonsoftJsonDefaults |
| Activout.RestClient.Newtonsoft.Json/NewtonsoftJsonDefaults.cs | Introduced a centralized defaults class for JSON settings and media types |
| Activout.RestClient.Newtonsoft.Json/JsonHelper.cs | Removed as part of the consolidation effort |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.