Skip to content

Move Newtonsoft.Json dependency to separate package#66

Merged
twogood merged 7 commits intomainfrom
Newtonsoft.Json
May 28, 2025
Merged

Move Newtonsoft.Json dependency to separate package#66
twogood merged 7 commits intomainfrom
Newtonsoft.Json

Conversation

@twogood
Copy link
Owner

@twogood twogood commented May 28, 2025

So that we eventually can make a System.Text.Json version as well. See #46

@twogood twogood requested a review from Copilot May 28, 2025 21:47
@twogood twogood self-assigned this May 28, 2025

This comment was marked as outdated.

@twogood twogood requested a review from Copilot May 28, 2025 22:08
@twogood twogood changed the title Newtonsoft.json Move Newtonsoft.Json dependency to separate package May 28, 2025

This comment was marked as outdated.

@twogood twogood requested a review from Copilot May 28, 2025 22:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the JSON serialization dependency by moving Newtonsoft.Json specific implementations into a dedicated package, laying the groundwork for a future System.Text.Json version.

  • Renames namespaces from Activout.RestClient.Serialization.Implementation and Activout.RestClient.Test to dedicated Newtonsoft.Json namespaces.
  • Updates project files and test suites to reference the new package and calls to the Newtonsoft-specific deserializer and extension method.
  • Introduces a new csproj for the separated package and updates dependency and project references accordingly.

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

File Description
Activout.RestClient.Newtonsoft.Json/JsonHelper.cs Changes namespace to reflect the new package structure.
Activout.RestClient.Newtonsoft.Json/Activout.RestClient.Newtonsoft.Json.csproj Introduces a new project file with the explicit Newtonsoft.Json dependency.
Activout.RestClient.Newtonsoft.Json.Test/* Updates test namespaces and client builder invocations to use the new Newtonsoft.Json specific API.
Comments suppressed due to low confidence (1)

Activout.RestClient.Newtonsoft.Json/JsonHelper.cs:3

  • The namespace update reflects the new package structure; ensure all internal references and documentation are updated for full consistency.
namespace Activout.RestClient.Newtonsoft.Json

</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
Copy link

Copilot AI May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider centralizing dependency version management if applicable, to ensure consistency across the project.

Copilot uses AI. Check for mistakes.
…t.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: David Eriksson <david@activout.se>
@twogood twogood marked this pull request as ready for review May 28, 2025 23:04
@twogood twogood merged commit 02d15b1 into main May 28, 2025
8 checks passed
@twogood twogood deleted the Newtonsoft.Json branch May 28, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants