Move Newtonsoft.Json dependency to separate package#66
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JSON serialization dependency by moving Newtonsoft.Json specific implementations into a dedicated package, laying the groundwork for a future System.Text.Json version.
- Renames namespaces from Activout.RestClient.Serialization.Implementation and Activout.RestClient.Test to dedicated Newtonsoft.Json namespaces.
- Updates project files and test suites to reference the new package and calls to the Newtonsoft-specific deserializer and extension method.
- Introduces a new csproj for the separated package and updates dependency and project references accordingly.
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Activout.RestClient.Newtonsoft.Json/JsonHelper.cs | Changes namespace to reflect the new package structure. |
| Activout.RestClient.Newtonsoft.Json/Activout.RestClient.Newtonsoft.Json.csproj | Introduces a new project file with the explicit Newtonsoft.Json dependency. |
| Activout.RestClient.Newtonsoft.Json.Test/* | Updates test namespaces and client builder invocations to use the new Newtonsoft.Json specific API. |
Comments suppressed due to low confidence (1)
Activout.RestClient.Newtonsoft.Json/JsonHelper.cs:3
- The namespace update reflects the new package structure; ensure all internal references and documentation are updated for full consistency.
namespace Activout.RestClient.Newtonsoft.Json
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> |
There was a problem hiding this comment.
[nitpick] Consider centralizing dependency version management if applicable, to ensure consistency across the project.
…t.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Eriksson <david@activout.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we eventually can make a System.Text.Json version as well. See #46