Skip to content

Enable nullable in project but disable in files#116

Merged
twogood merged 3 commits intomainfrom
nullable-enable-start-Activout.RestClient.Test
Oct 24, 2025
Merged

Enable nullable in project but disable in files#116
twogood merged 3 commits intomainfrom
nullable-enable-start-Activout.RestClient.Test

Conversation

@twogood
Copy link
Owner

@twogood twogood commented Oct 24, 2025

Summary by CodeRabbit

  • Chores
    • Enabled nullable reference type support in the test project build configuration to improve code quality and type safety standards.
    • Applied nullable reference type context settings to individual test files to maintain compatibility during migration to modern language standards.

@twogood twogood self-assigned this Oct 24, 2025
@twogood twogood enabled auto-merge (rebase) October 24, 2025 20:03
@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Nullable reference types are enabled at the project level in Activout.RestClient.Test.csproj, and #nullable disable directives are added to all 16 test files to preserve their existing nullability semantics.

Changes

Cohort / File(s) Summary
Project Configuration
Activout.RestClient.Test/Activout.RestClient.Test.csproj
Added <Nullable>enable</Nullable> to enable nullable reference type checks for the test project.
Test Files with Nullable Context Disabled
Activout.RestClient.Test/BodyArgumentFormPostTest.cs, Activout.RestClient.Test/CancellationTokenBodyTest.cs, Activout.RestClient.Test/DictionaryParameterTests.cs, Activout.RestClient.Test/ErrorResponseTextPlainTest.cs, Activout.RestClient.Test/HttpRequestMessageCollector.cs, Activout.RestClient.Test/HttpResponseMessageTest.cs, Activout.RestClient.Test/HttpStatusCodeTest.cs, Activout.RestClient.Test/LoggerFactoryHelpers.cs, Activout.RestClient.Test/MediaTypeTests.cs, Activout.RestClient.Test/MovieReviews/ErrorResponse.cs, Activout.RestClient.Test/MovieReviews/IMovieReviewService.cs, Activout.RestClient.Test/MultipartFormDataContentTest.cs, Activout.RestClient.Test/NonJsonRestClientTests.cs, Activout.RestClient.Test/NullParameterTests.cs, Activout.RestClient.Test/ParamConverterTests.cs, Activout.RestClient.Test/RestClientExceptionTest.cs
Added #nullable disable directive at the top of each file, opting out of nullable reference type checks for these test files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Nullable references now on the scene,
Yet tests stay mellow, just as they've been,
With disable charms in every test file,
We leap through logic with a nullity smile!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nullable-enable-start-Activout.RestClient.Test

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7141730 and 2f8b6d7.

📒 Files selected for processing (17)
  • Activout.RestClient.Test/Activout.RestClient.Test.csproj (1 hunks)
  • Activout.RestClient.Test/BodyArgumentFormPostTest.cs (1 hunks)
  • Activout.RestClient.Test/CancellationTokenBodyTest.cs (1 hunks)
  • Activout.RestClient.Test/DictionaryParameterTests.cs (1 hunks)
  • Activout.RestClient.Test/ErrorResponseTextPlainTest.cs (1 hunks)
  • Activout.RestClient.Test/HttpRequestMessageCollector.cs (1 hunks)
  • Activout.RestClient.Test/HttpResponseMessageTest.cs (1 hunks)
  • Activout.RestClient.Test/HttpStatusCodeTest.cs (1 hunks)
  • Activout.RestClient.Test/LoggerFactoryHelpers.cs (1 hunks)
  • Activout.RestClient.Test/MediaTypeTests.cs (1 hunks)
  • Activout.RestClient.Test/MovieReviews/ErrorResponse.cs (1 hunks)
  • Activout.RestClient.Test/MovieReviews/IMovieReviewService.cs (1 hunks)
  • Activout.RestClient.Test/MultipartFormDataContentTest.cs (1 hunks)
  • Activout.RestClient.Test/NonJsonRestClientTests.cs (1 hunks)
  • Activout.RestClient.Test/NullParameterTests.cs (1 hunks)
  • Activout.RestClient.Test/ParamConverterTests.cs (1 hunks)
  • Activout.RestClient.Test/RestClientExceptionTest.cs (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@twogood twogood merged commit 57e6aa9 into main Oct 24, 2025
8 of 9 checks passed
@twogood twogood deleted the nullable-enable-start-Activout.RestClient.Test branch October 24, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant