-
Notifications
You must be signed in to change notification settings - Fork 2
Add tests for ErrorResponse without JSON #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| using System.Net; | ||
| using System.Net.Http; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.Extensions.Logging; | ||
| using RichardSzalay.MockHttp; | ||
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace Activout.RestClient.Test; | ||
|
|
||
| public class ErrorResponseTextPlainTest(ITestOutputHelper outputHelper) | ||
| { | ||
| private const string BaseUri = "https://example.com/api"; | ||
|
|
||
| private readonly IRestClientFactory _restClientFactory = Services.CreateRestClientFactory(); | ||
| private readonly MockHttpMessageHandler _mockHttp = new(); | ||
| private readonly ILoggerFactory _loggerFactory = LoggerFactoryHelpers.CreateLoggerFactory(outputHelper); | ||
|
|
||
| private ITestService CreateTestService() | ||
| { | ||
| return _restClientFactory.CreateBuilder() | ||
| .With(_loggerFactory.CreateLogger<ErrorResponseTextPlainTest>()) | ||
| .With(_mockHttp.ToHttpClient()) | ||
| .BaseUri(BaseUri) | ||
| .Build<ITestService>(); | ||
| } | ||
|
|
||
| private ITestServiceWithCustomError CreateTestServiceWithCustomError() | ||
| { | ||
| return _restClientFactory.CreateBuilder() | ||
| .With(_loggerFactory.CreateLogger<ErrorResponseTextPlainTest>()) | ||
| .With(_mockHttp.ToHttpClient()) | ||
| .BaseUri(BaseUri) | ||
| .Build<ITestServiceWithCustomError>(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task TestErrorResponse_TextPlain_BadRequest_Async() | ||
| { | ||
| // arrange | ||
| _mockHttp | ||
| .When(HttpMethod.Get, $"{BaseUri}/resource") | ||
| .Respond(HttpStatusCode.BadRequest, "text/plain", "Invalid request parameter"); | ||
|
|
||
| var service = CreateTestService(); | ||
|
|
||
| // act | ||
| var exception = await Assert.ThrowsAsync<RestClientException>(() => service.GetResourceAsync()); | ||
|
|
||
| // assert | ||
| Assert.Equal(HttpStatusCode.BadRequest, exception.StatusCode); | ||
| Assert.NotNull(exception.ErrorResponse); | ||
| Assert.IsType<string>(exception.ErrorResponse); | ||
| Assert.Equal("Invalid request parameter", exception.GetErrorResponse<string>()); | ||
| Assert.Equal("Invalid request parameter", exception.Message); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task TestErrorResponse_TextPlain_BadRequest_CustomErrorMessage_Async() | ||
| { | ||
| // arrange | ||
| _mockHttp | ||
| .When(HttpMethod.Get, $"{BaseUri}/resource") | ||
| .Respond(HttpStatusCode.BadRequest, "text/plain", "Invalid request parameter"); | ||
|
|
||
| var service = CreateTestServiceWithCustomError(); | ||
|
|
||
| // act | ||
| var exception = await Assert.ThrowsAsync<RestClientException>(() => service.GetResourceAsync()); | ||
|
|
||
| // assert | ||
| Assert.Equal(HttpStatusCode.BadRequest, exception.StatusCode); | ||
| Assert.NotNull(exception.ErrorResponse); | ||
| Assert.IsType<CustomErrorMessage>(exception.ErrorResponse); | ||
| var customError = exception.GetErrorResponse<CustomErrorMessage>(); | ||
| Assert.Equal("Invalid request parameter", customError.Message); | ||
| } | ||
|
|
||
| [Path("resource")] | ||
| [ErrorResponse(typeof(string))] | ||
| public interface ITestService | ||
| { | ||
| [Get] | ||
| Task GetResourceAsync(); | ||
| } | ||
|
|
||
| [Path("resource")] | ||
| [ErrorResponse(typeof(CustomErrorMessage))] | ||
| public interface ITestServiceWithCustomError | ||
| { | ||
| [Get] | ||
| Task GetResourceAsync(); | ||
| } | ||
|
|
||
| public record CustomErrorMessage(string Message); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| using System.Net; | ||
| using System.Xml.Serialization; | ||
| using Microsoft.Extensions.Logging; | ||
| using RichardSzalay.MockHttp; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace Activout.RestClient.Xml.Test; | ||
|
|
||
| public class ErrorResponseXmlTest(ITestOutputHelper outputHelper) | ||
| { | ||
| private const string BaseUri = "https://example.com/api"; | ||
|
|
||
| private readonly IRestClientFactory _restClientFactory = Services.CreateRestClientFactory(); | ||
| private readonly MockHttpMessageHandler _mockHttp = new(); | ||
| private readonly ILoggerFactory _loggerFactory = LoggerFactoryHelpers.CreateLoggerFactory(outputHelper); | ||
|
|
||
| private ITestService CreateTestService() | ||
| { | ||
| return _restClientFactory.CreateBuilder() | ||
| .WithXml() | ||
| .With(_loggerFactory.CreateLogger<ErrorResponseXmlTest>()) | ||
| .With(_mockHttp.ToHttpClient()) | ||
| .BaseUri(BaseUri) | ||
| .Build<ITestService>(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task TestErrorResponse_Xml_BadRequest_Async() | ||
| { | ||
| // arrange | ||
| const string errorXml = """ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <error> | ||
| <code>400</code> | ||
| <message>Invalid request parameter</message> | ||
| </error> | ||
| """; | ||
| _mockHttp | ||
| .When(HttpMethod.Get, $"{BaseUri}/resource") | ||
| .Respond(HttpStatusCode.BadRequest, "text/xml", errorXml); | ||
|
|
||
| var service = CreateTestService(); | ||
|
|
||
| // act | ||
| var exception = await Assert.ThrowsAsync<RestClientException>(() => service.GetResourceAsync()); | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| // assert | ||
| Assert.Equal(HttpStatusCode.BadRequest, exception.StatusCode); | ||
| Assert.NotNull(exception.ErrorResponse); | ||
| Assert.IsType<XmlErrorResponse>(exception.ErrorResponse); | ||
| var errorResponse = exception.GetErrorResponse<XmlErrorResponse>(); | ||
| Assert.Equal(400, errorResponse.Code); | ||
| Assert.Equal("Invalid request parameter", errorResponse.Message); | ||
| } | ||
|
|
||
| [Path("resource")] | ||
| [ErrorResponse(typeof(XmlErrorResponse))] | ||
| public interface ITestService | ||
| { | ||
| [Get] | ||
| Task GetResourceAsync(); | ||
| } | ||
|
|
||
| [XmlRoot("error")] | ||
| public class XmlErrorResponse | ||
| { | ||
| [XmlElement("code")] | ||
| public int Code { get; set; } | ||
|
|
||
| [XmlElement("message")] | ||
| public string Message { get; set; } = ""; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.