Update sbt to 1.5.2 #288
Closed
Update sbt to 1.5.2 #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@felixbr thanks for the PR! Sorry for the delay in getting back to you. I don't think this clashes with anything, let me double check. |
mosesn
approved these changes
Jun 2, 2021
Contributor
mosesn
left a comment
mosesn
left a comment
There was a problem hiding this comment.
From poking around, this looks good. I'm going to switch to 1.5.3 and try to apply your patches to scrooge / finagle / twitter-server / finatra, and hopefully we'll be able to merge this in soon-ish.
Contributor
|
Sorry for the delay, I've run into a bunch of sbt weirdness. New sbt versions apparently rearrange the classpath. I'm hoping to have it sorted today or tomorrow, @eed3si9n has been tremendously helpful! |
Contributor
|
Thanks for your patience, this was merged in! 659e818 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
sbt supports Scala 3 natively in the recent versions (e.g. 1.5.x) and I want the build to be ready for Scala 3.
Solution
Updating sbt from 1.3.10 to 1.5.2
Result
sbt is updated to 1.5.2 and most warnings addressed (i.e. auto-reloading, unused settings, and migration to slash-syntax for settings)
As usual, I cannot tell if this clashes with any Twitter-internal things, so please tell me if it does.