refactor(http-ratelimiting): clean up actor #2471
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-http-ratelimiting
vilgotf
commented
Oct 24, 2025
| match old_entry { | ||
| MapEntry::Occupied(mut entry) => { | ||
| entry.insert(headers.bucket); | ||
| entry.insert(mem::take(&mut headers.bucket)); |
Member
Author
There was a problem hiding this comment.
Cannot call reset_after() if headers is partially moved.
vilgotf
force-pushed
the
vilgotf/clean-actor
branch
from
d2bf5d9 to
435ed83
Compare
vilgotf
force-pushed
the
vilgotf/clean-actor
branch
from
435ed83 to
4a0f42d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts some code into separate methods and uses let-chaining to shrink the main actor function length.
Depends upon #2469