fix(http): Correct error type for in_flight error #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7596ff
approved these changes
Aug 11, 2021
spring4175
previously approved these changes
Aug 17, 2021
spring4175
approved these changes
Aug 17, 2021
Contributor
|
Thanks for the PR |
spring4175
added a commit
that referenced
this pull request
Aug 18, 2021
Additions Add 6 new HTTP API error codes: - 10049: Unknown stream - 10050: Unknown premium server subscribe cooldown - 10070: Unknown Guild Scheduled Event - 10071: Unknown Guild Scheduled Event User - 50095: This server is not available in your location - 50097: This server needs monetization enabled in order to perform this action ([#1094] - [@Erk-]). Fixes Fix `ResponseFuture` returning mismatched `RequestTimedOut` and `RequestError` error type variants ([#1100] - [@vilgotf]). Enhancements Improve the performance of `Response::bytes` ([#1103] - [@vilgotf]). Add `[#must_use]` to typed HTTP request builders ([#1099] - [@zeylahellyer]). [@Erk-]: https://github.com/Erk- [@vilgotf]: https://github.com/vilgotf [@zeylahellyer]: https://github.com/zeylahellyer [#1103]: #1103 [#1100]: #1100 [#1099]: #1099 [#1094]: #1094 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Aug 25, 2021
The `ResponseFuture`'s underlying HTTP client execution future has a timeout on it. The `match` branch for how to handle the result of the execution has three cases: 1. The request being successfully executed and getting an HTTP client response back 2. The request timing out 3. An error while executing the request In the handling of cases two and three the error would be transformed into our own error type, but the handling for it is reversed: if a request timed out we'd say there was an error executing the request and vice versa. This fixes that by reversing the error types in the branches.
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Aug 25, 2021
Additions Add 6 new HTTP API error codes: - 10049: Unknown stream - 10050: Unknown premium server subscribe cooldown - 10070: Unknown Guild Scheduled Event - 10071: Unknown Guild Scheduled Event User - 50095: This server is not available in your location - 50097: This server needs monetization enabled in order to perform this action ([twilight-rs#1094] - [@Erk-]). Fixes Fix `ResponseFuture` returning mismatched `RequestTimedOut` and `RequestError` error type variants ([twilight-rs#1100] - [@vilgotf]). Enhancements Improve the performance of `Response::bytes` ([twilight-rs#1103] - [@vilgotf]). Add `[#must_use]` to typed HTTP request builders ([twilight-rs#1099] - [@zeylahellyer]). [@Erk-]: https://github.com/Erk- [@vilgotf]: https://github.com/vilgotf [@zeylahellyer]: https://github.com/zeylahellyer [twilight-rs#1103]: twilight-rs#1103 [twilight-rs#1100]: twilight-rs#1100 [twilight-rs#1099]: twilight-rs#1099 [twilight-rs#1094]: twilight-rs#1094 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors should be the other way around