Skip to content

Extract Granola webhook event verification - #30814

Open
ehconitin wants to merge 1 commit into
mainfrom
ehco/granola-shared-webhook-verification
Open

ehconitin wants to merge 1 commit into
mainfrom
ehco/granola-shared-webhook-verification

Conversation

@ehconitin

@ehconitin ehconitin commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Context

First replacement for #30808. Personal Granola sync will reuse the workspace webhook's event verification.

Change

Extract the existing signature, header, payload schema, and event ID checks into a shared parser. Preserve the workspace handler's registration checks, acceptance rules, error responses, and import behavior.

Verification

  • Independent local review approved commit d157480098b as low risk against the twenty-eng review standard and Factory risk rubric.
  • Granola lint, typecheck, CLI build, 144 unit tests, and 15 deployed integration tests passed.

View guided diff

@twenty-ci-bot-public

Copy link
Copy Markdown

🚀 Preview Environment Ready!

Your preview environment is available at: https://knee-battle-primarily-symptoms.trycloudflare.com

This environment will automatically shut down after 5 hours.

@twenty-ci-bot-public

Copy link
Copy Markdown

🤖 PR Review

Check Result
🔍 Build safety ⏭️ skipped — external-only
🧭 Triage ⏭️ skipped — external-only
📐 Quality ✅ passed
🛡️ Security ✅ passed
🚦 Auto-approve ✅ passed — complexity low
🔐 Permissions ⏭️ skipped: no endpoint permission change

🛡️ Security Review

✅ No high-severity vulnerabilities detected.


🚦 Auto-approve

✅ Eligible for auto-approval — low-complexity, no high-blast-radius paths.

  • 🧠 Complexity: low
  • 📏 Size: +123 / -29 lines across 3 file(s)

View details

Automated pre-review — human approval still required.

@twenty-ci-bot-public

Copy link
Copy Markdown

✅ Quality review · no findings

Safe to merge — no high-level findings

High-level — A small refactor inside the Granola app: it moves the webhook signature check and payload parsing into a tested util that reuses the existing verifyStandardWebhookSignature and GRANOLA_WEBHOOK_PAYLOAD_SCHEMA, keeps the same behaviour, adds no duplicate code, changes no shared layer and needs no rollout steps.
Low-level — No rule violations found — 103 rule questions over 3 piece(s) of 3 file(s)


Reviewed against the pr-review standard — high-level then low-level. Advisory; human review still required. Run details.

@CoreTeamTwenty CoreTeamTwenty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — cleared automated quality and security review and is low-complexity.

  • Quality: passed
  • Security: passed
  • Auto-approve: passed — complexity low

Automated approval — a human still merges, and this is re-evaluated on every push.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants