Skip to content

Conversation

@GeoSot
Copy link
Member

@GeoSot GeoSot commented Sep 14, 2022

closes #37107

@GeoSot GeoSot requested a review from a team as a code owner September 14, 2022 09:54
@GeoSot GeoSot force-pushed the gs/drop-tab-autofocus branch from b875991 to 3fb0153 Compare September 15, 2022 19:33
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since referenced issue had fix confirmed.

@GeoSot GeoSot force-pushed the gs/drop-tab-autofocus branch from 3fb0153 to 73b0995 Compare September 20, 2022 14:18
@GeoSot GeoSot merged commit 1510c25 into main Sep 20, 2022
@GeoSot GeoSot deleted the gs/drop-tab-autofocus branch September 20, 2022 14:20
XhmikosR pushed a commit that referenced this pull request Oct 2, 2022
* fix: keyboard functionality

* test: add tests

* Add some focus spies in 2 other unit tests

Co-authored-by: Julien Déramond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5.2.x tab.show() makes the page scroll to tab

3 participants