Skip to content

Conversation

@julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 4, 2022

Description

Add missing .dropup for the dropup centered example.

Motivation & Context

The arrow is in the wrong direction; should point to the top.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [w] All new and existing tests passed

Related issues

N/A

Live preview

@julien-deramond julien-deramond marked this pull request as draft March 4, 2022 12:13
@julien-deramond
Copy link
Member Author

julien-deramond commented Mar 4, 2022

⚠️ Apparently there is a regression between c0f3036 and bb7664d. Testing it on the main branch gives:

Edit: see #35968

@mdo
Copy link
Member

mdo commented Mar 8, 2022

Fixed by #35973—no need for the second class now :). Thanks and good looking out! <3

@mdo mdo closed this Mar 8, 2022
@julien-deramond
Copy link
Member Author

@mdo Please reconsider reopening it because IMO #35973 doesn't fix the issue with the direction of the dropup centered arrow.

With #35973 (https://deploy-preview-35973--twbs-bootstrap.netlify.app/docs/5.1/components/dropdowns/#dropup-centered) and so in the main branch now, the arrow is pointing down:
Screenshot from 2022-03-09 07-42-26

With this PR (and the .dropup class) (https://deploy-preview-35948--twbs-bootstrap.netlify.app/docs/5.1/components/dropdowns/#dropup-centered), the arrow direction is the same than for the other dropup examples (arrow is pointing up):
Screenshot from 2022-03-09 07-43-10

@GeoSot
Copy link
Member

GeoSot commented Mar 11, 2022

CC @mdo we may reconsider this

@XhmikosR XhmikosR changed the title Missing .dropup in dropup centered example docs: add missing .dropup in dropup centered example Mar 11, 2022
@XhmikosR XhmikosR force-pushed the main-jd-missing-dropup-class branch from b482e8f to e57222e Compare March 11, 2022 13:58
@XhmikosR XhmikosR merged commit 5bdd5e0 into twbs:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants