Skip to content

Remove firefox workaround for ::file-selector-button margin#32064

Merged
XhmikosR merged 3 commits into
twbs:mainfrom
emilio:patch-1
Nov 6, 2020
Merged

Remove firefox workaround for ::file-selector-button margin#32064
XhmikosR merged 3 commits into
twbs:mainfrom
emilio:patch-1

Conversation

@emilio

@emilio emilio commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

As per https://bugzilla.mozilla.org/show_bug.cgi?id=1673895,
this workaround shouldn't be necessary in FF83+.

TODO:

  • Remove workarounds for .form-control-sm & .form-control-lg

Preview: https://deploy-preview-32064--twbs-bootstrap.netlify.app/docs/5.0/forms/form-control/#file-input

@emilio emilio requested a review from a team as a code owner November 5, 2020 13:34
@XhmikosR

XhmikosR commented Nov 5, 2020

Copy link
Copy Markdown
Member

We support Firefox >= 60

Firefox >= 60

@XhmikosR XhmikosR closed this Nov 5, 2020
@emilio

emilio commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

That pseudo-element is Firefox 82+, see the above bug.

@emilio

emilio commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

cc @MartijnCuppens

@MartijnCuppens MartijnCuppens reopened this Nov 5, 2020
@MartijnCuppens

Copy link
Copy Markdown
Member

@emilio, this will be added to FF83 beta 9 I assume? Can we test it somewhere, because I can only download beta 8 from https://www.mozilla.org/en-US/firefox/channel/desktop/?

@MartijnCuppens MartijnCuppens changed the title Remove firefox workaround for ::file-selector-button margin. Remove firefox workaround for ::file-selector-button margin Nov 5, 2020
@emilio

emilio commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

@MartijnCuppens yes, it should be in 83b9, but you can also test it on a Nightly build from https://nightly.mozilla.org

@MartijnCuppens

MartijnCuppens commented Nov 5, 2020

Copy link
Copy Markdown
Member

LGTM in Nightly (Dutch preview):
image

In FF82, there will be a little more padding, but that's acceptable imo:
image

Thanks for the PR, @emilio!

@ffoodd

ffoodd commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

Just to be sure @MartijnCuppens, following up @XhmikosR comment: I assume this screenshot is the intended look & feel for Firefox < 83?

Capture d’écran de 2020-11-05 16-49-38

@emilio

emilio commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

That'd be FF <82, I guess.

@ffoodd

ffoodd commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

≤ 82, < 83 :)

@MartijnCuppens

Copy link
Copy Markdown
Member

I assume this screenshot is the intended look & feel for Firefox < 83?

For FF ≤ 81, yup!

@XhmikosR XhmikosR merged commit c1bb1ac into twbs:main Nov 6, 2020
@emilio emilio deleted the patch-1 branch November 6, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants