tests: tweak Jasmine usage by XhmikosR · Pull Request #32046 · twbs/bootstrap

XhmikosR · 2020-11-02T11:20:11Z

Notes:

I think I'd prefer if we could make the rules throw an error instead of a warning, but I can't find an easy way to do it so we'd need to specify all the rules we want and set them as errors
jasmine/expect-single-argument has false warnings with expect().nothing()
jasmine/prefer-toHaveBeenCalledWith would be nice to have AFAICT, but it would need more code changes so I disabled it for now

After #32043 this branch should have zero warnings.

* jasmine/expect-matcher * jasmine/prefer-jasmine-matcher Found with `eslint-plugin-jasmine`

XhmikosR added js v5 tests labels Nov 2, 2020

XhmikosR force-pushed the main-xmr-eslint-jasmine branch from 58b5a1a to 095a8e7 Compare November 2, 2020 12:53

Johann-S approved these changes Nov 2, 2020

View reviewed changes

tests: tweak Jasmine usage

509f48b

* jasmine/expect-matcher * jasmine/prefer-jasmine-matcher Found with `eslint-plugin-jasmine`

XhmikosR marked this pull request as ready for review November 2, 2020 14:10

XhmikosR requested a review from a team as a code owner November 2, 2020 14:10

XhmikosR force-pushed the main-xmr-eslint-jasmine branch from 095a8e7 to 509f48b Compare November 2, 2020 14:11

XhmikosR changed the title ~~tests: add eslint-plugin-jasmine~~ tests: tweak Jasmine usage Nov 2, 2020

XhmikosR merged commit c9f8fa4 into main Nov 2, 2020

XhmikosR deleted the main-xmr-eslint-jasmine branch November 2, 2020 14:13

Provide feedback