Move href attribute first#31835
Merged
Merged
Conversation
mdo
reviewed
Oct 13, 2020
mdo
left a comment
mdo
left a comment
Member
There was a problem hiding this comment.
I like including href first so it's clearer earlier in the line what's being imported, if that makes sense. I could go either way though since these aren't regularly updated or anything.
XhmikosR
force-pushed
the
XhmikosR-patch-1
branch
from
d72f36f to
46e9457
Compare
XhmikosR
force-pushed
the
XhmikosR-patch-1
branch
from
5cbc2f5 to
634f182
Compare
mdo
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
hrefattribute first@mdo not sure what the order should be? If it's supposed to be the other way around let me know and I'll update the branch.