carousel: add missing to description and fix nextwhenvisible description#31809
Merged
Conversation
XhmikosR
changed the title
to description and fix nextwhenvisible description
Member
|
BTW this is duplicate of #31800 |
Contributor
Author
Johann-S
reviewed
Oct 2, 2020
Johann-S
approved these changes
Oct 2, 2020
XhmikosR
reviewed
Oct 2, 2020
| </tr> | ||
| <tr> | ||
| <td><code>nextWhenVisible</code></td> | ||
| <td>Don't cycle carousel to next when the page isn't visible or the carousel or its parent isn't visible. <strong>Returns to the caller before the target item has been shown</strong> |
Member
There was a problem hiding this comment.
@mdo or @patrickhlauke for word proofing. I feel like a "the" is missing?
Member
|
@Johann-S does this need a backport or is the option present only in v5? |
Member
|
yep we should backport this in v4 too 👍 |
Member
|
I don't see the option at all in v4-dev docs, so I guess we'll need to manually backport it. I'll add it to the 4.5.3 project but any patch to backport it is welcome. |
Contributor
Author
Manual Backport : #31851 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the to method and corrected nextWhenVisible description in Corousel Component documentation.
Fixes #31788