Wrap home content in <main> & use <section>#31580
Merged
Merged
Conversation
mdo
approved these changes
Sep 4, 2020
mdo
left a comment
mdo
left a comment
Member
There was a problem hiding this comment.
I think this all makes sense to me!
Member
|
How about the other layouts? We aren't using layouts hierarchy yet. |
Contributor
Author
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followups content should probably be in a landmark to improve discoverability for ATs; thus I wrapped them in
main, and also usedsections too since that's basically what this element is for.This one is not critical at all, opinions are welcome.
BTW: our current template for docs also have its intro content (
h1and lead) outside any landmark—thus not discoverable by users navigating with landmarks. It'd require to revamp the whole grid layout to change this: should I suggest a fix?