fix tooltip hide method when already hidden

[Hiws]

Fixes the error displayed when closing a modal with a tooltip that was never shown.

Closes: #31110

[XhmikosR]

I wonder if we have more cases like this one?

[Johann-S]

Can you add a unit test please ?

[Johann-S]

I'm more concerned about listening to a modal hiding in our tooltip component, for me we shouldn't do that @XhmikosR

[XhmikosR]

I'm more concerned about listening to a modal hiding in our tooltip component, for me we shouldn't do that @XhmikosR

Also, true. Does this code come from v4? You rewrote most of v5's JS code :)

[Johann-S]

Yep it comes from our v4

[Hiws]

I'm more concerned about listening to a modal hiding in our tooltip component, for me we shouldn't do that @XhmikosR

It makes sense why it's there (if that's what you're questioning), since it's a bit awkward that if you open a popover/tooltip and then close the modal.
The popover/tooltip will be open the next time you open the modal.

but I'm not sure if it makes more sense to look for tooltips in the modal code, or listen for modal closing in the tooltip code.

[Johann-S]

That's the reason yes, but is it really a good thing ? IMO it should be handled by our users to delete their tooltip if needed

[Hiws]

Perhaps.
I guess the current implementation limits it so they can't keep it open. Even if they wanted to.
While if the code was removed, it would keep it open, while still allowing the users to specifically close them if they wish.

[Johann-S]

Anyway you fix is good @Hiws but can you add a unit test please ?

[Hiws]

Anyway you fix is good @Hiws but can you add a unit test please ?
@Johann-S

Tried writing this test for 2 hours, and it looks like it's working now.
However, I've never really written unit tests before, so not sure if it's correct or not.

[XhmikosR]

I think the test should be in modal not in tooltip :)

[Hiws]

I think the test should be in modal not in tooltip :)

Ii feel like this case isn't specifically tied to modals, but the tooltip's hide method being run without the show method ever being ran.
Which is why i placed it under the tooltip tests and not modal.

[XhmikosR]

The error your patch fixes is in modal.js so that's where it should be tested that we don't throw.

[XhmikosR]

NVM, you are right, I need to sleep.

[Hiws]

NVM, you are right, I need to sleep.

I'll take part of the blame for having a bad title 😉

[Johann-S]

just my last comment and we are good to go here @Hiws thanks for your work 👍

[polRk]

Before merge, or alpha 2, use on child component style="pointer-events: none;"

<button class="btn btn-light" data-toggle="tooltip" data-placement="top" title="Tooltip on top">
    <svg width="18" height="18" style="pointer-events: none;" ><use xlink:href="#heart" /></svg>
</button>

[mdo]

Sorry for being out of the loop, what's the status of this one?

[mdo]

Pulling from Alpha 2 given unclear status.

[Johann-S]

We are waiting for @Hiws to do a last change and rebase his branch

[Hiws]

Sorry for the delay.

I'm not quite sure what you mean with you should call it twice and except nothing.

[Johann-S]

You're right it was good like that thanks 👌

Edit: Since everything is good it should land in Alpha 2