Easier disabled state customization for button variants#30639
Merged
Conversation
mdo
approved these changes
Jun 16, 2020
mdo
left a comment
mdo
left a comment
Member
There was a problem hiding this comment.
Let's document this in our Migration guide (and explain it's new in alpha 2 somehow, I can work on that). Perhaps we also do some Sass references in the buttons docs?
ffoodd
force-pushed
the
master-fod-disabled-button-args
branch
from
fe3bac6 to
0faa9ea
Compare
Contributor
Author
|
I added a mention in the migration page, not sure about the wording but at least there's something, now :) Not sure about Sass reference in the buttons docs either, looks like a meta feature for all components—as requested several times, isn't it? |
Member
|
Waiting to merge #31122 first so that we place all alpha2 changes in the new section. |
mdo
approved these changes
Jul 11, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* feat(buttons): easier disabled state customization * docs(migration): mention new arguments for disabled state in button-variant() * Update migration.md Co-authored-by: XhmikosR <xhmikosr@gmail.com> Co-authored-by: Mark Otto <markd.otto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can seamlessly ease the
disabledstate customization in thebutton-variant()mixin by adding dedicated arguments, which default values are the previously used ones.I may have to mention this somewhere in the docs, if you're OK with the feature :)