Skip to content

Conversation

@zalog
Copy link
Contributor

@zalog zalog commented Apr 16, 2020

This PR let us set a empty $grid-breakpoints: (); list, if for any reason we want to remove all breakpoints.

Fixes sass error in case $grid-breakpoints list is empty:

Error: argument `$list` of `nth($list, $n)` must not be empty

@zalog zalog requested a review from a team as a code owner April 16, 2020 21:03
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@MartijnCuppens MartijnCuppens merged commit a8883a3 into twbs:master Apr 17, 2020
@zalog
Copy link
Contributor Author

zalog commented Apr 17, 2020

Tnks M, I can backport it :D

MartijnCuppens added a commit that referenced this pull request Apr 17, 2020
@zalog zalog deleted the zalog-functions-assert branch April 17, 2020 17:20
XhmikosR pushed a commit that referenced this pull request Apr 18, 2020
XhmikosR pushed a commit that referenced this pull request Apr 21, 2020
XhmikosR pushed a commit that referenced this pull request Apr 28, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants