Switch to the Coveralls Action #29478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
master-xmr-cov-action-2
branch
2 times, most recently
from
3a51e86 to
217ed68
Compare
Member
Will that break the new integration? If not, let's keep tests from failing and remove afterwards maybe? |
Member
Author
|
This will only break for PRs or branches that might still use the old way. For master we won't have any problem. For v4-dev, I will cherry pick it in #29482 after this PR is merged. |
XhmikosR
force-pushed
the
master-xmr-cov-action-2
branch
from
e0caac3 to
3bf5aaf
Compare
Member
Author
|
We are also getting rid of one devDependency BTW. |
This comment has been minimized.
This comment has been minimized.
XhmikosR
force-pushed
the
master-xmr-cov-action-2
branch
2 times, most recently
from
3754c7f to
fae7cd0
Compare
This comment has been minimized.
This comment has been minimized.
XhmikosR
force-pushed
the
master-xmr-cov-action-2
branch
from
573415d to
b47560b
Compare
Member
Author
|
This is blocked until the extra comments issue is solved |
XhmikosR
force-pushed
the
master-xmr-cov-action-2
branch
2 times, most recently
from
e471868 to
b84f7b2
Compare
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
XhmikosR
force-pushed
the
master-xmr-cov-action-2
branch
from
b84f7b2 to
1380a95
Compare
Member
Author
|
The comments issue seems fixed so it should be OK to switch to this. |
Member
Author
|
@mdo you can remove the |
Johann-S
approved these changes
Nov 18, 2019
XhmikosR
added a commit
that referenced
this pull request
Nov 18, 2019
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
XhmikosR
added a commit
that referenced
this pull request
Nov 25, 2019
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
Requires #29458 to be merged.Fixes #29457