Skip to content

Added !important to sr-only and sr-only-focusable SASS mixins #28701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jakobud wants to merge 3 commits into from
Closed

Added !important to sr-only and sr-only-focusable SASS mixins #28701

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57e61ab
Added !important to sr-only and sr-only-focusable SASS mixins
Jakobud Apr 28, 2019
b63e575
Added stylelint disable rule comment for no-important
Jakobud Apr 28, 2019
3173299
Merge branch 'master' into feature/screenreader-css-rules-important
Jakobud Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions scss/mixins/_screen-reader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
// stylelint-disable declaration-no-important

// Only display content to screen readers
//
// See: https://a11yproject.com/posts/how-to-hide-content/
// See: https://hugogiraudel.com/2016/10/13/css-hide-and-seek/

@mixin sr-only {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
overflow: hidden;
clip: rect(0, 0, 0, 0);
white-space: nowrap;
border: 0;
position: absolute !important;
width: 1px !important;
height: 1px !important;
padding: 0 !important;
overflow: hidden !important;
clip: rect(0, 0, 0, 0) !important;
white-space: nowrap !important;
border: 0 !important;
}

// Use in conjunction with .sr-only to only display content when it's focused.
Expand All @@ -23,11 +25,11 @@
@mixin sr-only-focusable {
&:active,
&:focus {
position: static;
width: auto;
height: auto;
overflow: visible;
clip: auto;
white-space: normal;
position: static !important;
width: auto !important;
height: auto !important;
overflow: visible !important;
clip: auto !important;
white-space: normal !important;
}
}